Saving Marks Should Include User's X, Y, Zoom, etc #844 #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
approved these changes
Mar 28, 2024
This was referenced Mar 28, 2024
|
This didn't work as expected and ended up showing variable information (e.g. changing zoom when viewing changed the recorded zoom on the annotation). It may be related to effects from #943 , but I've reverted it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added X, Y (image coordinate ）and zoom to the pop-panel
Motivation
Because until now, it was not possible to check the image coordinate and zooming information of the area annotated in mouse mode.
Testing
Before
After
Questions
please check whether my PR matches your issue #844 or not.